Skip to content

Conversation

@ddaribo
Copy link
Contributor

@ddaribo ddaribo commented Aug 5, 2025

Closes #16087 [Part of Alignment with WC date range picker]

  • adds built-in igx-picker-clear for single input
  • abstracts the click event subscription in the PickerBase, so that all picker elements could respond to a clear action by a projected igx-picker-clear
  • two inputs remain unchanged by default - their template is the input group's, so no built-in elements will be enforced. The icons can be projected by users, if required. Logged a task to modify the samples to include toggle & clear icons, to keep them aligned to the WC DRP.
  • adding the built-in clear icon also led to the following change, which is intentional and corresponds to the WC DRP - before for single input, the click over the entire input opened the calendar even in dropdown mode (in dialog it should be like this). Now the picker is opened when clicking the toggle icon and not the input in dropdown mode for singe input.
  • For two inputs in dialog mode, the picker should be opened by clicking the toggle icon or the inputs (ref).

Additional information (check all that apply):

  • Bug fix
  • New functionality
  • Documentation
  • Demos
  • CI/CD

Checklist:

  • All relevant tags have been applied to this PR
  • This PR includes unit tests covering all the new code (test guidelines)
  • This PR includes API docs for newly added methods/properties (api docs guidelines)
  • This PR includes feature/README.MD updates for the feature docs
  • This PR includes general feature table updates in the root README.MD
  • This PR includes CHANGELOG.MD updates for newly added functionality
  • This PR contains breaking changes
  • This PR includes ng update migrations for the breaking changes (migrations guidelines)
  • This PR includes behavioral changes and the feature specification has been updated with them

@ddaribo ddaribo requested a review from ChronosSF August 5, 2025 14:20
ChronosSF
ChronosSF previously approved these changes Aug 8, 2025
@ddaribo ddaribo force-pushed the bpachilova/drp-clear-icon-16087 branch from 88507e2 to 8aa2eef Compare August 14, 2025 08:41
@ddaribo ddaribo requested a review from ChronosSF August 21, 2025 13:41
@MonikaKirkova MonikaKirkova added 💥 status: in-test PRs currently being tested ✅ status: verified Applies to PRs that have passed manual verification and removed ❌ status: awaiting-test PRs awaiting manual verification 💥 status: in-test PRs currently being tested labels Aug 26, 2025
@ChronosSF ChronosSF added the squash-merge Merge PR with "Squash and Merge" option label Aug 27, 2025
@ChronosSF
Copy link
Member

@ddaribo , please resolve the conflicts

@ddaribo
Copy link
Contributor Author

ddaribo commented Aug 28, 2025

@ddaribo , please resolve the conflicts

done

@ChronosSF ChronosSF merged commit 42cfa28 into master Aug 28, 2025
5 checks passed
@ChronosSF ChronosSF deleted the bpachilova/drp-clear-icon-16087 branch August 28, 2025 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📈 enhancement 📅 date-range-picker squash-merge Merge PR with "Squash and Merge" option version: 20.1.x ✅ status: verified Applies to PRs that have passed manual verification

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Date Range Picker] Add built-in clear icon

4 participants